Create a unified macro to derive all the encodable traits #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The derives are getting very verbose, which is especially bad for users that want to create their own custom structs. This adds an attribute macro that simply derives these traits as appropriate. I also found an issue with the XML parsing and custom codegen that required an unpleasant workaround.
einarmo
force-pushed
the
super-encodable-macro
branch
from
fb69c9b to
815a87b
Compare
svanharmelen
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The derives are getting very verbose, which is especially bad for users that want to create their own custom structs. This adds an attribute macro that simply derives these traits as appropriate.
I also found an issue with the XML parsing and custom codegen that required an unpleasant workaround.