Fix handling of UaStatusCodeErrors in UaProcessor.process_message
#1570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed that raising a `BadOutOfRangeError` in a server callback set through `Server.subscribe_server_callback` resulted in a *BadInternalError* on the client side (tested with UaExpert) rather than the expected *BadOutOfRange*. But raising a `ServiceError(ua.StatusCodes.BadOutOfRange)` instead would show the the expected *BadOutOfRange* error in the client. The reason for this idiosyncrasy was that `UaStatusCodeError`s were not explicitly caught. Therefore the "default" `except Exception` handler would be used which resulted in a `ua.StatusCode(ua.StatusCodes.BadInternalError)` to be sent to the client instead of the actual status code of the error that occurred. This commit changes the behavior such that the status code of `UaStatusCodeError`s is respected the same way as it's already done for `ServiceError`s so that the client correctly receives the status code of the `raise`d error. See also FreeOpcUa#1563 (reply in thread)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that raising a
BadOutOfRangeErrorin a server callback set throughServer.subscribe_server_callbackresulted in a BadInternalError on the client side (tested with UaExpert) rather than the expected BadOutOfRange. But raising aServiceError(ua.StatusCodes.BadOutOfRange)instead would show the the expected BadOutOfRange error in the client.The reason for this idiosyncrasy was that
UaStatusCodeErrors were not explicitly caught. Therefore the "default"except Exceptionhandler would be used which resulted in aua.StatusCode(ua.StatusCodes.BadInternalError)to be sent to the client instead of the actual status code of the error that occurred.This commit changes the behavior such that the status code of
UaStatusCodeErrors is respected the same way as it's already done forServiceErrors so that the client correctly receives the status code of theraised error.See also #1563 (reply in thread)