Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IA32 compilation with common IRQ entry disabled #1137

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

Ryzee119
Copy link
Contributor

@Ryzee119 Ryzee119 commented Sep 7, 2024

Fix IA32 compilation with common IRQ entry disabled

Description

This change fixes compilation errors when using IA32 port when configUSE_COMMON_INTERRUPT_ENTRY_POINT is set to 0.
The follow compilation error is generated:

portable/GCC/IA32_flat/port.c:669:14: error: use of undeclared identifier 'xInterruptHandlerTable'
  669 |     else if( xInterruptHandlerTable[ ulVectorNumber ] != NULL )

Test Steps

  • Modify template_configuration/FreeRTOSConfig.h as follows:
-#define configMAX_API_CALL_INTERRUPT_PRIORITY    0
+#define configMAX_API_CALL_INTERRUPT_PRIORITY    2  //Just to pass IA32 port.c checks
  • Compiling will generate the above error.
gcc -m32 -march=pentium -c -o port.o portable/GCC/IA32_flat/port.c -DconfigISR_STACK_SIZE=256 -DconfigUSE_COMMON_INTERRUPT_ENTRY_POINT=0 -Iexamples/template_configuration -Iinclude -Iportable/GCC/IA32_flat

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

N/A

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Ryzee119 Ryzee119 requested a review from a team as a code owner September 7, 2024 00:57
@aggarg aggarg merged commit 93e8199 into FreeRTOS:main Sep 9, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants