Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test fix for PR#625 #1049

Closed
wants to merge 5 commits into from

Conversation

kar-rahul-aws
Copy link
Member

Description

This PR adds fix for Unit Test for FreeRTOS+Kernel PR#625 and duplicate PR#719

Test Steps

make -C tasks

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@kar-rahul-aws kar-rahul-aws requested a review from a team as a code owner July 24, 2023 19:06
@kar-rahul-aws kar-rahul-aws marked this pull request as draft July 24, 2023 19:06
@karver8
Copy link

karver8 commented Sep 2, 2023

@kar-rahul-aws Thanks for doing this. This looks exactly like what I expected so seems good to me!

@karver8
Copy link

karver8 commented Sep 9, 2023

@kar-rahul-aws Ultimately I think that these tests probably need to be moved into the FreeRTOS-Kernel repository, so these unit tests can be updated atomically with the source. Until then, we can work around this problem in the following steps:

  1. Adding listLIST_IS_EMPTY_IgnoreAndReturn( pdTRUE ) instead of listLIST_IS_EMPTY_ExpectAnyArgsAndReturn( pdTRUE ), merging this into FreeRTOS:main.
  2. Merging the fix into the kernel main branch.
  3. Creating another PR in this repository to replace listLIST_IS_EMPTY_IgnoreAndReturn( pdTRUE ) with listLIST_IS_EMPTY_ExpectAnyArgsAndReturn( pdTRUE ) and update the submodule.

I can create the PR if your team thinks this is acceptable.

@kar-rahul-aws
Copy link
Member Author

Duplicate PR has been merged, hence closing this issue.

@kar-rahul-aws kar-rahul-aws deleted the ut_fix_pr_625 branch October 24, 2023 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants