-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating the coreMQTT submodule pointer #124
Open
DakshitBabbar
wants to merge
12
commits into
FreeRTOS:main
Choose a base branch
from
DakshitBabbar:mqtt-v3.0.0-release
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+152
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orrectly on Mac machines
tony-josi-aws
previously approved these changes
Mar 3, 2025
aggarg
reviewed
Mar 3, 2025
Co-authored-by: Gaurav-Aggarwal-AWS <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
core_mqtt_config_defaults.h
file in thecore_mqtt_agent_config_defaults.h
.core_mqtt_config.h
included in thecore_mqtt.h
file whose macros is used by a couple of more files likefreertos_command_pool.c
in some old demos (like the old OTA demos). But in the new version this includes is removed from thecore_mqtt.h
file and added in thecore_mqtt_config_defaults.h
file. A simple solution to this problem was to add thecore_mqtt_config_defaults.h
in thecore_mqtt_agent_config_defaults.h
which is included in thecore_mqtt_agent.h
that is used by the files that require the macros.Test Steps
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.