Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the coreMQTT submodule pointer #124

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

DakshitBabbar
Copy link
Member

@DakshitBabbar DakshitBabbar commented Feb 21, 2025

Description

  • Updates the coreMQTT submodule pointer to the latest commit of the library.
  • Includes the core_mqtt_config_defaults.h file in the core_mqtt_agent_config_defaults.h.
    • This is done because the older version of coreMQTT (v1.x.x) has core_mqtt_config.h included in the core_mqtt.h file whose macros is used by a couple of more files like freertos_command_pool.c in some old demos (like the old OTA demos). But in the new version this includes is removed from the core_mqtt.h file and added in the core_mqtt_config_defaults.h file. A simple solution to this problem was to add the core_mqtt_config_defaults.h in the core_mqtt_agent_config_defaults.h which is included in the core_mqtt_agent.h that is used by the files that require the macros.
  • Updates README for correct commands to build unit tests
  • Modifies the cmake files for building the unit tests successfully on mac machines
  • Modifies the unit tests for full coverage (initially coverage was different for mac and linux)

Test Steps

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@DakshitBabbar DakshitBabbar changed the title Mqtt v3.0.0 release Updating the coreMQTT submodule pointer Feb 21, 2025
tony-josi-aws
tony-josi-aws previously approved these changes Mar 3, 2025
Co-authored-by: Gaurav-Aggarwal-AWS <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants