This repository has been archived by the owner on May 28, 2022. It is now read-only.
Zeroconf support for headless server #648
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How about also adding a basic CLI command for scanning for Freeseer servers? |
dbrenden
force-pushed
the
broadcast
branch
2 times, most recently
from
69fd00c
to
a044d69
Compare
| def setup_parser_discover(subparsers): | ||
| """Setup discover command parser""" | ||
| parsers = subparsers.add_parser('discover', help='Search for freeseer servers on the network') | ||
| parsers.add_argument("-t", "--timeout", help="Poll for freeseer servers continually", action="store") |
There was a problem hiding this comment.
I think the default action is 'store', and you can avoid int(...) later on by setting type=int. Furthermore I think argparse will also automatically add '-t' if it sees '--timeout'.
There was a problem hiding this comment.
You need to explicitly declare '-t' for it to be a command line option.
|
Why don't you move this stuff into its own submodule folder? It seems weird having it mixed with the rest of the API stuff, especially since you have it separated into announcer.py and listener.py. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow flask server to broadcast over public ip. Use Zeroconf protocol to publish the service (using avahi), allowing any client with Zeroconf to search and connect to any Freeseer client on their network.