✨ Add some new features to assets api + tests upgrade #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nek-
force-pushed
the
some-features-on-assets-api
branch
from
bdcf02e to
33677c6
Compare
alexandre-lass
approved these changes
Mar 10, 2023
Nek-
force-pushed
the
some-features-on-assets-api
branch
3 times, most recently
from
e8d089a to
0f55d5e
Compare
- GET a specific asset - DELETE a tag on an asset Misc: add a missing parameter on the AssetModel class.
The docker is not working: Nyholm/roave-bc-check-docker#32
Nek-
force-pushed
the
some-features-on-assets-api
branch
from
0f55d5e to
a094b03
Compare
Nek-
changed the title
Nek-
force-pushed
the
some-features-on-assets-api
branch
4 times, most recently
from
3ec5a9c to
a094b03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I tried to add some little features:
But the CI was not working (at all). I decided to fix this in explicitly separated commits. I can make a PR for each of them if you want so, or I can change any of them if you wish.
To review all of this, I highly recommend reviewing commit by commit.
Side note for anybody that wants to use this branch, you can use the master branch of my repository https://github.com/Nek-/localise.biz which is maintained (at least contains those fixes).