Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved event handler api #411

Merged
merged 5 commits into from
Jan 8, 2025
Merged

Improved event handler api #411

merged 5 commits into from
Jan 8, 2025

Conversation

christianmat
Copy link
Contributor

Adds a new API for handling user flow state changes.

Testing done:

  • Wrote new unit/integration tests
  • Tested API in Storybook
  • Ran all existing Storybook integration tests

@christianmat christianmat requested a review from dfltr January 8, 2025 01:29
dfltr
dfltr approved these changes Jan 8, 2025
View reviewed changes
packages/js-api/src/core/frigade.ts Outdated
}
break

default:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since event is typed to FlowChangeEvent, this could be flow.any for clarity since it can't have any other value at this point.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@christianmat christianmat merged commit 9bdfcb3 into main Jan 8, 2025
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfltr dfltr dfltr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christianmat @dfltr