Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: migrate from @web3modal to @reown/appkit #474

Draft
wants to merge 45 commits into
base: main
Choose a base branch
from
Draft

feat: migrate from @web3modal to @reown/appkit #474

wants to merge 45 commits into from
+2,263 −7,622

Conversation

helciofranco
Copy link
Member

@helciofranco helciofranco commented Feb 3, 2025 •
edited
Loading

Summary

We’ve been receiving bug reports related to WalletConnectorConnector and SolanaConnector, so we took this opportunity to migrate to the latest @appkit/reown, which resolves these issues.

This migration also simplifies a lot of the existing implementation, making the codebase easier to maintain.

📷 Rabby EVM Phantom Multichain
rabby_ethereum.mov
phantom_multichain.mov

Checklist

  • I've added error handling for all actions/requests, and verified how this error will show on UI. (or there was no error handling)
  • I've reviewed all the copy changed/added in this PR, using AI if needed. (or there was no copy changes)
  • I've included the reference to the issues being closed from Github and/or Linear (or there was no issues)
  • I've changed the Docs to reflect my changes (or it was not needed)
  • I've put docs links where it may be helpful (or it was not needed)
  • I checked the resulting UI both in Light and Dark mode (or no UI changes were made)
  • I reviewed the entire PR myself (preferably, on GH UI)

@helciofranco
feat: sync evm connector with app kit declare global
d3c58e1
@helciofranco
feat: add @reown/appkit as external, same as wagmi etc
522963f
@helciofranco
feat: migrate from web3modal and walletconnect to @reown/appkit
4c5a462
@helciofranco
chore: update comment about deprecated web3 modal
d0fa9fd
@helciofranco
feat: migrate solana connector to @reown/appkit
2c2c689
@helciofranco
feat: add @reown-connector – to allow users to connect SVM/EVM in sam…
5c22105 
…e connector
@helciofranco
feat: remove unused packages
9629380
@helciofranco
feat: remove useless subscription channel
8ce49c2
@helciofranco
fix: remove unused stuff
3b807f6
@helciofranco
feat: add appkit to the next example
fb92513
@helciofranco
feat: remove vite
8d9a43d
@helciofranco
feat: add appkit to the e2e-tests runner
5b3ec5d
@helciofranco
feat: move connect ownership to the reown connector
d69f4b5
@helciofranco
fix: evm flow with signature
c0f2031
@helciofranco
feat: remove eth unused code
ea65d0d
@helciofranco
chore: add missing type def
ca67eb5
@helciofranco
feat: simplify a lot how we handle connection and reconnection in evm
54f9434
@helciofranco
fix: flow where connecting dialog doesn't close
d35e841
@helciofranco
fix: add missing emitConnect everywhere
ff99973
@helciofranco
chore: remove unused code
e17ff6c
@helciofranco
docs: add changeset
88d0a80
@helciofranco
chore: remove useless method
c8a8f13
@helciofranco
chore: sync implementation with evm
f412704
@helciofranco
fix: adjust reconnecting flow
36d8382
@helciofranco helciofranco self-assigned this Feb 3, 2025
@helciofranco helciofranco linked an issue Feb 3, 2025 that may be closed by this pull request
Upgrade web3modal to @reown/appkit #467
Open
@vercel Vercel
Copy link

vercel bot commented Feb 3, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuel-connectors ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 9:06pm

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025 •
edited
Loading

Coverage Report for Fuel Wallet (./packages/fuel-wallet)

Status Category Percentage Covered / Total
🔵 Lines 61.63% 143 / 232
🔵 Statements 61.63% 143 / 232
🔵 Functions 56.66% 17 / 30
🔵 Branches 86.95% 20 / 23
File CoverageNo changed files found.
Generated in workflow #1390 for commit 2bb40f0 by the Vitest Coverage Report Action

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025 •
edited
Loading

Coverage Report for Fuel Development Wallet (./packages/fuel-development-wallet)

Status Category Percentage Covered / Total
🔵 Lines 100% 19 / 19
🔵 Statements 100% 19 / 19
🔵 Functions 100% 1 / 1
🔵 Branches 100% 1 / 1
File CoverageNo changed files found.
Generated in workflow #1390 for commit 2bb40f0 by the Vitest Coverage Report Action

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025 •
edited
Loading

Coverage Report for Fuelet Wallet (./packages/fuelet-wallet)

Status Category Percentage Covered / Total
🔵 Lines 100% 24 / 24
🔵 Statements 100% 24 / 24
🔵 Functions 100% 1 / 1
🔵 Branches 100% 1 / 1
File CoverageNo changed files found.
Generated in workflow #1390 for commit 2bb40f0 by the Vitest Coverage Report Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luizstacio luizstacio Awaiting requested review from luizstacio luizstacio will be requested when the pull request is marked ready for review luizstacio is a code owner

@pedronauck pedronauck Awaiting requested review from pedronauck pedronauck will be requested when the pull request is marked ready for review pedronauck is a code owner

@LuizAsFight LuizAsFight Awaiting requested review from LuizAsFight LuizAsFight will be requested when the pull request is marked ready for review LuizAsFight is a code owner

@arthurgeron arthurgeron Awaiting requested review from arthurgeron arthurgeron will be requested when the pull request is marked ready for review arthurgeron is a code owner

@rodrigobranas rodrigobranas Awaiting requested review from rodrigobranas rodrigobranas will be requested when the pull request is marked ready for review rodrigobranas is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@helciofranco helciofranco

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade web3modal to @reown/appkit Upgrade Reown
1 participant
@helciofranco