fix: resolve dentos comments

crates/services/p2p/src/peer_manager.rs

@@ -315,9 +315,12 @@ impl ConnectionState {
         SeqLockWriter<ConnectionState>,
         SeqLockReader<ConnectionState>,
     ) {
-        SeqLock::new(Self {
-            peers_allowed: true,
-        })
+        // ConnectionState < 64 bytes, so it's safe to use SeqLock
+        unsafe {
+            SeqLock::new(Self {
+                peers_allowed: true,
+            })
+        }
     }
 
     pub fn available_slot(&self) -> bool {

crates/services/src/seqlock.rs

@@ -12,7 +12,7 @@ use std::{
 /// A simple implementation of a sequential lock.
 /// some usage of unsafe, T must be Copy
 #[derive(Debug)]
-pub struct SeqLock<T> {
+pub struct SeqLock<T: Copy> {
     sequence: AtomicU64,
     data: UnsafeCell<T>,
 }
@@ -21,6 +21,7 @@ unsafe impl<T: Send> Sync for SeqLock<T> {}
 
 /// The writer handle for the `SeqLock`.
 /// Only one writer exists for a `SeqLock`.
+/// There is no Clone bound since we want to enforce only one writer.
 #[derive(Debug)]
 pub struct SeqLockWriter<T> {
     lock: std::sync::Arc<SeqLock<T>>,
@@ -90,11 +91,10 @@ impl<T> SeqLock<T> {
     ///  !!WARNING!!
     /// ONLY USE IF ALL THE BELOW CRITERIA ARE MET
     ///  1. Internal data < 64 bytes
-    ///  2. Data is Copy
-    ///  3. ONLY 1 writer
-    ///  4. VERY frequent reads
+    ///  2. ONLY 1 writer
+    ///  3. VERY frequent reads
     #[allow(clippy::new_ret_no_self)]
-    pub fn new(data: T) -> (SeqLockWriter<T>, SeqLockReader<T>) {
+    pub unsafe fn new(data: T) -> (SeqLockWriter<T>, SeqLockReader<T>) {
         let lock = Self {
             sequence: AtomicU64::new(0),
             data: UnsafeCell::new(data),
@@ -117,7 +117,7 @@ mod tests {
 
     #[test]
     fn test_seqlock__provides_correct_values_in_order() {
-        let (writer, reader) = SeqLock::new(42);
+        let (writer, reader) = unsafe { SeqLock::new(42) };
         let iterations = 100;
 
         let writer = {
@@ -146,7 +146,7 @@ mod tests {
 
     #[test]
     fn test_seqlock__single_threaded() {
-        let (writer, reader) = SeqLock::new(42);
+        let (writer, reader) = unsafe { SeqLock::new(42) };
 
         writer.write(|data| {
             *data = 100;

crates/services/txpool_v2/src/service.rs

@@ -800,7 +800,9 @@ where
         config,
     );
 
-    let (current_height_writer, current_height_reader) = SeqLock::new(current_height);
+    // BlockHeight is < 64 bytes, so we can use SeqLock
+    let (current_height_writer, current_height_reader) =
+        unsafe { SeqLock::new(current_height) };
 
     Service::new(Task {
         chain_id,