feat(gas_price_service): improve performance of SharedGasPriceAlgo by replacing underlying RwLock with SeqLock #2528
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
Merging blocked by #2524, please review that first :)
Linked Issues/PRs
Description
The
SharedGasPriceAlgo
implementations,SharedV1Algorithm
,SharedV0Algorithm
make use of anArc<parking_lot::Mutex<A>>
, however, since the internal type used is relatively small, we can make use ofSeqLock
introduced in #2524, as it meets the requirements of using it, i.e -you might wonder that we might have "torn reads" but as long as the data fits in a single cache line we are safe here, and since the size of
AlgorithmV1
is 40 bytes (padding incl), it fits in a 64-byte cache-line, and hence is safe to use with SeqLockfetching the gas price is a very frequent operation, and although it might be cached by higher layers, we benefit from the SeqLock, as presented in the following benchmark result:
the baseline for the benchmark was generated using this branch: chore/baseline-shared-gas-price-algo-bench
Checklist
Before requesting review
After merging, notify other teams
[Add or remove entries as needed]