impl Display for Receipt
#901
Conversation
| @@ -156,6 +156,51 @@ pub enum Receipt { | |||
| }, | |||
| } | |||
|
|
|||
| impl core::fmt::Display for Receipt { | |||
There was a problem hiding this comment.
Why can't we derive the implementation with all fields?=D
There was a problem hiding this comment.
Regarding all fields - I thought it may be just a bit too much details, which, when needed, could be retrieved by Debug. I prefer Display to be more concise, targeted on humans, not developers :)
I have no strong opinions here, so if you prefer to have all fields, I can just stick derive_more::Display without any custom #[display(fmt = attributes.
Let me know what you think.
fuel-tx/src/receipt.rs
Outdated
| Receipt::Call { id, .. } => write!(f, "Call({})", id), | ||
| Receipt::Return { id, .. } => write!(f, "Return({})", id), | ||
| Receipt::ReturnData { id, .. } => write!(f, "ReturnData({})", id), | ||
| Receipt::Panic { id, .. } => write!(f, "Panic({})", id), |
There was a problem hiding this comment.
do you think we can display the panic reason in a meaningful way?
fuel-vm/fuel-tx/src/receipt.rs
Line 65 in 2fc9c5d
There was a problem hiding this comment.
Yes, since PanicReason is a simple repr(u8) enum, we can just debug-print it to get an output like:
Panic(id=0000000000000000000000000000000000000000000000000000000000000000, reason=OutOfGas)
Updated in 7e04606
rafal-ch
requested review from
Dentosal,
MitchTurner and
Voxelot
as code owners
This PR implements
DisplayforReceiptfor easier logging.Once this is merged and released, there will be a follow-up PR to the
fuel-coreto get rid of this boilerplate.Follow-up PR: FuelLabs/fuel-core#2616
Checklist
Before requesting review