feat: cache latest fuels version
#3350
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Peter Smith <[email protected]>
Dhaiwat10
requested review from
digorithm,
arboleya,
Torres-ssf,
danielbate,
nedsalk,
petertonysmith94 and
maschad
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Dhaiwat10
changed the title
fuels version
CodSpeed Performance ReportMerging #3350 will not alter performanceComparing Summary
|
|
Coverage Report:
Changed Files:
|
Torres-ssf
reviewed
Oct 22, 2024
Comment on lines
+9
to
+18
| const data: { version: string } | null = await Promise.race([ | ||
| new Promise((resolve) => { | ||
| setTimeout(() => resolve(null), 3000); | ||
| }), | ||
| fetch('https://registry.npmjs.org/fuels/latest').then((response) => response.json()), | ||
| ]); | ||
|
|
||
| if (!data) { | ||
| throw new Error('Failed to fetch latest fuels version.'); | ||
| } |
There was a problem hiding this comment.
Since an error is being thrown anyway, we can reject the promise instead of resolving it on line 11.
Comment on lines
+20
to
+22
| if (!cachedVersion) { | ||
| return null; | ||
| } |
There was a problem hiding this comment.
Is it possible for the cache file to exist but cachedVersion to be null?
Comment on lines
+24
to
+27
| const { mtimeMs: cacheTimestamp } = fs.statSync(FUELS_VERSION_CACHE_FILE); | ||
| const hasCacheExpired = Date.now() - cacheTimestamp > FUELS_VERSION_CACHE_TTL; | ||
|
|
||
| return hasCacheExpired ? null : cachedVersion; |
There was a problem hiding this comment.
Is it worth saving the timestamp along the cache so we don't need to call statSync ?
Torres-ssf
reviewed
Oct 22, 2024
| import fs from 'fs'; | ||
| import path from 'path'; | ||
|
|
||
| export const FUELS_VERSION_CACHE_FILE = path.join(__dirname, 'FUELS_VERSION'); |
There was a problem hiding this comment.
I believe we should add this to the .gitignore file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fuelsversion #3177Summary
This PR adds a basic local cache for the latest
fuelsversion fetched by thefuelsCLI.Checklist