feat: support optimistic concurrency control headers #3462
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This comment was marked as resolved.
This comment was marked as resolved.
Torres-ssf
force-pushed
the
st/feat/add-headers-for-optimistic-concurrency-control
branch
from
d80fbd7 to
cce2ba3
Compare
This comment was marked as resolved.
This comment was marked as resolved.
|
Blocked by the next |
arboleya
requested changes
Feb 17, 2025
| const gqlClient = new GraphQLClient(this.urlWithoutAuth, { | ||
| fetch: (input: RequestInfo | URL, requestInit?: RequestInit) => | ||
| fetchFn(input.toString(), requestInit || {}, this.options), | ||
| responseMiddleware: (response: GraphQLClientResponse<unknown> | Error) => { | ||
| this.setCurrentBlockHeight(response as { extensions: unknown }); |
There was a problem hiding this comment.
@Torres-ssf Because the node waiting time threshold is dynamic and can be changed or disabled at any time, we must validate the response and implement the whole timing/check/retry independently.
4 tasks
|
Closing in favor of #3741 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
In this release, we:
fuel_block_heightSummary
flowchart TD Initialize[init: currentBlockHeight = 0] --> prepareRequest[prepare request] prepareRequest --> isRequestBlockSensitive[is request block height sensitive] isRequestBlockSensitive --> isSensitive[yes] isRequestBlockSensitive --> isNotSensitive[no] isSensitive --> addBlockHeight[inform required block height] addBlockHeight --> sendRequest[send request] isNotSensitive --> sendRequest[send request] sendRequest --> response[response has block height error?] response --> blockHeightError(yes) response --> noBlockHeightError(no) blockHeightError --> shouldRetry(should retry?) shouldRetry --> retry(yes) shouldRetry --> noRetry(no) retry --> wait(wait) wait --> sendRequest noRetry --> throwError(throw error) noBlockHeightError --> extractBlockHeight(extract block height from response) extractBlockHeight --> isHigher isHigher[is value higher than current?] isHigher --> higher[yes] isHigher --> nonHigher[no] higher --> updateBlockHeight[set new value] updateBlockHeight --> End[end] nonHigher --> EndChecklist