feat: enhance the communication between SDK and wallet #3735
+1,360
−376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: implement flags for the transaction request * chore: combine flags for `isEstimated` and `isFunded` * chore: remove `isSigned` from witness updates * changeset * revert experimental changes * Aligned to the new re-spec * update to state * Update state * chore: fix connector test * lintfix * Apply suggestions from code review
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
petertonysmith94
changed the title
petertonysmith94
changed the title
* chore: moved chainInfo serialization * chore: added serialize chain info * move chain info helper * add deprecation notice * chore: added deserialize of nodeInfo * Added the ability to restore the provider chain + node info cache * consolidate serialization * serialize provider cache * pass serialized chain to connector * lintfix * lintfix * changeset * changeset * lintfix
Torres-ssf
reviewed
Feb 27, 2025
packages/account/src/account.ts
Outdated
Comment on lines
754
to
758
| if (params.skipCustomFee) { | ||
| const chainId = await this.provider.getChainId(); | ||
| request.updateState(chainId, 'signed'); | ||
| return { request, state: 'signed' }; | ||
| } |
There was a problem hiding this comment.
Could there be cases where the skipCustomFee flag is used, but the transaction is not yet signed?
There was a problem hiding this comment.
Yes, that could be a possibility.
There was a problem hiding this comment.
On top of the above, I also think a method named validate should not mutate its received parameters.
There was a problem hiding this comment.
On top of the above, I also think a method named validate should not mutate its received parameters.
Torres-ssf
reviewed
Feb 27, 2025
packages/account/src/providers/transaction-request/transaction-request.ts
Show resolved
Hide resolved
Torres-ssf
reviewed
Feb 27, 2025
Torres-ssf
reviewed
Feb 27, 2025
Comment on lines
55
to
68
| export type FuelConnectorSendTxParams = { | ||
| skipCustomFee?: boolean; | ||
| onBeforeSend?: (txRequest: TransactionRequest) => Promise<TransactionRequest>; | ||
| provider?: { | ||
| url: string; | ||
| cache?: SerializedProviderCache; | ||
| }; | ||
| data?: { | ||
| transactionSummary?: SerializedTransactionSummary; | ||
| estimatedGasPrice?: string; | ||
| latestGasPrice?: string; | ||
| }; | ||
| state?: TransactionStateFlag['state']; | ||
| }; |
There was a problem hiding this comment.
I've noticed that the interface name being used here differs from the one being specified within this PR's description. Is this intentional?
There was a problem hiding this comment.
Do you mean the SerializedProviderCache?
I wanted to show the full payload in the description so expanded the SerializedProviderCache to get:
provider: {
url: string,
cache?: {
consensusParameterTimestamp?: string,
chain: SerializedChainInfo,
nodeInfo: SerializedNodeInfo,
}
},
nedsalk
reviewed
Feb 27, 2025
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
|
Coverage Report:
Changed Files:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
In this release, we:
Summary
SendTransactionJsonRpcspecification:undefinedfundedsignedskipCustomFee.Providerusing the serialised cache:Checklist