-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements fully working hierarchical lexical scopes. #6784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
920ca89
to
aaed7cc
Compare
CodSpeed Performance ReportMerging #6784 will degrade performances by 58.87%Comparing Summary
Benchmarks breakdown
|
c5f0f07
to
62fd6dd
Compare
xunilrj
reviewed
Dec 30, 2024
792e419
to
8d57419
Compare
90c1d89
to
f2f0b31
Compare
tritao
reviewed
Jan 8, 2025
tritao
reviewed
Jan 8, 2025
tritao
previously approved these changes
Jan 8, 2025
…on_ctx.namespace lexical scopes.
This optimization is now removed from the TraitMAp because it breaks the insert_implementation_for_type of mutable references.
This reverts commit 8d57419.
b18daec
to
c47a31f
Compare
15c81e4
to
4db723d
Compare
tritao
approved these changes
Jan 10, 2025
IGI-111
approved these changes
Jan 10, 2025
@FuelLabs/tooling, can you take a look? |
JoshuaBatty
approved these changes
Jan 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
code quality
compiler: frontend
Everything to do with type checking, control flow analysis, and everything between parsing and IRgen
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the missing elements for the hierarchical lexical scopes.
TypeCheckContext no longer uses cloned namespaces. Instead, we push and pop lexical scopes.
For this to work multiple places that used current_items now either use root_items or traverse the lexical scopes.
Checklist
Breaking*
orNew Feature
labels where relevant.