-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix extract_type_parameters regarding primitive types #6965
Merged
+49
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #6965 will not alter performanceComparing Summary
|
IGI-111
previously approved these changes
Feb 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congrats on figuring this one out 🕵️
ironcev
requested changes
Feb 27, 2025
test/src/e2e_vm_tests/test_programs/should_pass/language/method_on_primitives/.gitignore
Outdated
Show resolved
Hide resolved
test/src/e2e_vm_tests/test_programs/should_pass/language/method_on_primitives/Forc.toml
Outdated
Show resolved
Hide resolved
df058f0
to
9f3fcbf
Compare
ironcev
approved these changes
Feb 27, 2025
JoshuaBatty
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is part of #5110. It fixes a problem that improves the usability of slices.
When a method is returned from the "method resolution algorithm", if any generic is involved, it is returned as its generic form. So for example, if a method
len
is called onVec<u8>
, we return something likefn len(self: Vec<T>)
.Later we monomorphize
T
intou8
. To do that we run a "pattern match" to realize that we need to replaceT
withu8
.In this case, the bug was that we were not considering that some primitive types have "implicit type parameters".
This was found whilst creating more tests for #6933, because I was not able to call the
len
method defined for slices as:Checklist
Breaking*
orNew Feature
labels where relevant.