Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix extract_type_parameters regarding primitive types #6965

Merged
merged 4 commits into from
Feb 28, 2025

Conversation

xunilrj
Copy link
Contributor

@xunilrj xunilrj commented Feb 26, 2025

Description

This PR is part of #5110. It fixes a problem that improves the usability of slices.

When a method is returned from the "method resolution algorithm", if any generic is involved, it is returned as its generic form. So for example, if a method len is called on Vec<u8>, we return something like fn len(self: Vec<T>).

Later we monomorphize T into u8. To do that we run a "pattern match" to realize that we need to replace T with u8.

In this case, the bug was that we were not considering that some primitive types have "implicit type parameters".

This was found whilst creating more tests for #6933, because I was not able to call the len method defined for slices as:

impl<T> &[T] {
    pub fn len(self) -> u64 {
        ...
    }
}

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@xunilrj xunilrj self-assigned this Feb 26, 2025
@xunilrj xunilrj requested review from a team as code owners February 26, 2025 19:20
Copy link

codspeed-hq bot commented Feb 26, 2025

CodSpeed Performance Report

Merging #6965 will not alter performance

Comparing xunilrj/fix-extract-type-parameters (ae3eddb) with master (597ecfb)

Summary

✅ 22 untouched benchmarks

IGI-111
IGI-111 previously approved these changes Feb 27, 2025
Copy link
Contributor

@IGI-111 IGI-111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on figuring this one out 🕵️

@IGI-111 IGI-111 requested a review from a team February 27, 2025 04:29
@xunilrj xunilrj force-pushed the xunilrj/fix-extract-type-parameters branch from df058f0 to 9f3fcbf Compare February 27, 2025 13:23
@xunilrj xunilrj requested review from ironcev and IGI-111 February 27, 2025 13:24
@xunilrj xunilrj mentioned this pull request Aug 19, 2024
18 tasks
@xunilrj xunilrj enabled auto-merge (squash) February 27, 2025 15:27
@xunilrj xunilrj merged commit b7d1539 into master Feb 28, 2025
41 checks passed
@xunilrj xunilrj deleted the xunilrj/fix-extract-type-parameters branch February 28, 2025 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants