Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Resync Buffer #3955

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Fix Resync Buffer #3955

merged 1 commit into from
Jan 17, 2025

Conversation

TechnikTil
Copy link
Contributor

Briefly describe the issue(s) fixed.

This PR fixes the buffer that resync has while doing its job. It does this by keeping the song going while its resyncing. Probably a way better way to do this, but this will work for now.

Include any relevant screenshots or videos.

@github-actions github-actions bot added pr: haxe PR modifies game code. pr: documentation PR modifies documentation or README files. size: large A large pull request with more than 100 changes. labels Dec 25, 2024
@TechnikTil TechnikTil changed the base branch from main to develop December 25, 2024 16:53
@TechnikTil
Copy link
Contributor Author

whoops forgot to do that

Kade-github
Kade-github approved these changes Dec 30, 2024
View reviewed changes
Copy link
Contributor

@Kade-github Kade-github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Significantly reduces stutters for me on resync, good changes.

@EliteMasterEric EliteMasterEric added status: pending triage Awaiting review. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. and removed status: pending triage Awaiting review. pr: documentation PR modifies documentation or README files. labels Jan 17, 2025
@EliteMasterEric EliteMasterEric self-assigned this Jan 17, 2025
@EliteMasterEric EliteMasterEric added this to the 0.6.0 milestone Jan 17, 2025
@EliteMasterEric EliteMasterEric merged commit 22d41d2 into FunkinCrew:develop Jan 17, 2025
6 checks passed
@Hundrec Hundrec added the type: major bug Involves a major bug, including crashes, softlocks, or issues blocking progression label Jan 22, 2025
@AbnormalPoof AbnormalPoof mentioned this pull request Jan 22, 2025
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kade-github Kade-github Kade-github approved these changes

Assignees
No one assigned
Labels
pr: haxe PR modifies game code. size: large A large pull request with more than 100 changes. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. type: major bug Involves a major bug, including crashes, softlocks, or issues blocking progression
Projects
None yet
Milestone
0.6.0 (Pit Stop 2)
Development

Successfully merging this pull request may close these issues.
4 participants
@TechnikTil @Kade-github @EliteMasterEric @Hundrec