Initial code commit #3
Annotations
24 warnings
unnecessary map of the identity function:
src/main.rs#L214
warning: unnecessary map of the identity function
--> src/main.rs:214:20
|
214 | .iter()
| ____________________^
215 | | .map(|(k, v)| (k, v))
| |_________________________________^ help: remove the call to `map`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_identity
= note: `#[warn(clippy::map_identity)]` on by default
|
called `is_none()` after searching an `Iterator` with `find`:
src/main.rs#L148
warning: called `is_none()` after searching an `Iterator` with `find`
--> src/main.rs:148:8
|
148 | if headers
| ________^
149 | | .keys()
150 | | .find(|k| "server_name".eq_ignore_ascii_case(k))
151 | | .is_none()
| |__________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some
= note: `#[warn(clippy::search_is_some)]` on by default
help: consider using
|
148 ~ if !headers
149 + .keys().any(|k| "server_name".eq_ignore_ascii_case(&k))
|
|
single-character string constant used as pattern:
crates/http-service/src/lib.rs#L519
warning: single-character string constant used as pattern
--> crates/http-service/src/lib.rs:519:49
|
519 | Ok(SmolStr::from(prefix.replace("-", "_")))
| ^^^ help: consider using a `char`: `'-'`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
|
single-character string constant used as pattern:
crates/http-service/src/lib.rs#L518
warning: single-character string constant used as pattern
--> crates/http-service/src/lib.rs:518:32
|
518 | if prefix.contains("-") {
| ^^^ help: consider using a `char`: `'-'`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
= note: `#[warn(clippy::single_char_pattern)]` on by default
|
redundant closure:
crates/http-service/src/executor.rs#L150
warning: redundant closure
--> crates/http-service/src/executor.rs:150:60
|
150 | let body = resp.body.map_or_else(|| Body::empty(), |b| Body::from(b));
| ^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `Body::from`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
|
redundant closure:
crates/http-service/src/executor.rs#L150
warning: redundant closure
--> crates/http-service/src/executor.rs:150:42
|
150 | let body = resp.body.map_or_else(|| Body::empty(), |b| Body::from(b));
| ^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `Body::empty`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
= note: `#[warn(clippy::redundant_closure)]` on by default
|
the following explicit lifetimes could be elided: 'a:
crates/candle-wasi-nn/src/lib.rs#L73
warning: the following explicit lifetimes could be elided: 'a
--> crates/candle-wasi-nn/src/lib.rs:73:24
|
73 | fn as_dir_loadable<'a>(&'a mut self) -> Option<&'a mut dyn BackendFromDir> {
| ^^ ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
73 - fn as_dir_loadable<'a>(&'a mut self) -> Option<&'a mut dyn BackendFromDir> {
73 + fn as_dir_loadable(&mut self) -> Option<&mut dyn BackendFromDir> {
|
|
useless conversion to the same type: `wasmtime_wasi_nn::backend::BackendError`:
crates/candle-wasi-nn/src/lib.rs#L58
warning: useless conversion to the same type: `wasmtime_wasi_nn::backend::BackendError`
--> crates/candle-wasi-nn/src/lib.rs:58:24
|
58 | return Err(BackendError::InvalidNumberOfBuilders(1, builders.len()).into());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `BackendError::InvalidNumberOfBuilders(1, builders.len())`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `#[warn(clippy::useless_conversion)]` on by default
|
calls to `push` immediately after creation:
crates/http-backend/src/lib.rs#L355
warning: calls to `push` immediately after creation
--> crates/http-backend/src/lib.rs:355:5
|
355 | / let mut headers = vec![];
356 | | headers.push(("Fastedge-Hostname".to_string(), original_host));
357 | | headers.push((
358 | | "Fastedge-Scheme".to_string(),
... |
362 | | .to_string(),
363 | | ));
| |_______^ help: consider using the `vec![]` macro: `let headers = vec![..];`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push
= note: `#[warn(clippy::vec_init_then_push)]` on by default
|
unnecessary closure used to substitute value for `Option::None`:
crates/http-backend/src/lib.rs#L359
warning: unnecessary closure used to substitute value for `Option::None`
--> crates/http-backend/src/lib.rs:359:9
|
359 | / original_url
360 | | .scheme_str()
361 | | .unwrap_or_else(|| "http")
| |______________------------------------^
| |
| help: use `unwrap_or(..)` instead: `unwrap_or("http")`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
= note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default
|
using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)`:
crates/http-backend/src/lib.rs#L317
warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)`
--> crates/http-backend/src/lib.rs:317:21
|
317 | host.or_else(|| original_uri.host().and_then(|h| Some(h.to_string())))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `original_uri.host().map(|h| h.to_string())`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map
= note: `#[warn(clippy::bind_instead_of_map)]` on by default
|
redundant closure:
crates/http-backend/src/lib.rs#L243
warning: redundant closure
--> crates/http-backend/src/lib.rs:243:44
|
243 | let body = req.body.unwrap_or_else(|| vec![]);
| ^^^^^^^^^ help: replace the closure with `Vec::new`: `std::vec::Vec::new`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
= note: `#[warn(clippy::redundant_closure)]` on by default
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
crates/http-backend/src/lib.rs#L221
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> crates/http-backend/src/lib.rs:221:32
|
221 | headers.extend(self.propagate_headers.clone().into_iter());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `self.propagate_headers.clone()`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/iter/traits/collect.rs:415:18
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
crates/http-backend/src/lib.rs#L220
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> crates/http-backend/src/lib.rs:220:32
|
220 | headers.extend(backend_headers(&original_url, original_host).into_iter());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `backend_headers(&original_url, original_host)`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/iter/traits/collect.rs:415:18
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
called `is_none()` after searching an `Iterator` with `find`:
crates/http-backend/src/lib.rs#L143
warning: called `is_none()` after searching an `Iterator` with `find`
--> crates/http-backend/src/lib.rs:143:20
|
143 | if headers
| ____________________^
144 | | .iter()
145 | | .find(|(k, _)| k.eq_ignore_ascii_case(HOST_HEADER_NAME))
146 | | .is_none()
| |______________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some
= note: `#[warn(clippy::search_is_some)]` on by default
help: consider using
|
143 ~ if !headers
144 + .iter().any(|(k, _)| k.eq_ignore_ascii_case(HOST_HEADER_NAME))
|
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
crates/http-backend/src/lib.rs#L141
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> crates/http-backend/src/lib.rs:141:32
|
141 | headers.extend(self.propagate_headers.clone().into_iter());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `self.propagate_headers.clone()`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/iter/traits/collect.rs:415:18
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `#[warn(clippy::useless_conversion)]` on by default
|
constants have by default a `'static` lifetime:
crates/http-backend/src/lib.rs#L23
warning: constants have by default a `'static` lifetime
--> crates/http-backend/src/lib.rs:23:26
|
23 | const HOST_HEADER_NAME: &'static str = "host";
| -^^^^^^^---- help: consider removing `'static`: `&str`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes
= note: `#[warn(clippy::redundant_static_lifetimes)]` on by default
|
build
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions-rs/toolchain@v1, actions-rs/cargo@v1, actions-rs/[email protected], actions-rs/clippy-check@v1, actions-rs/audit-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
build
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1, actions-rs/[email protected], actions-rs/clippy-check@v1, actions-rs/audit-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
build
Unable to download cargo-audit == latest from the tool cache: Error: Unexpected HTTP response: 403
|