Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python formatting and linting #249

Merged
merged 3 commits into from
Aug 17, 2023
Merged

Conversation

jgiannuzzi
Copy link
Member

  • Add pipenv basic environment with mlflow, black, and isort
  • Install black and isort VS Code extensions
  • Setup VS Code for automatic Python formatting
  • Add Makefile targets for formatting and linting
  • Add Python linting to CI
  • Format Python files

- Add pipenv basic environment with mlflow, black, and isort
- Install black and isort VS Code extensions
- Setup VS Code for automatic Python formatting
- Add Makefile targets for formatting and linting
- Add Python linting to CI
@jgiannuzzi jgiannuzzi marked this pull request as ready for review August 17, 2023 15:35
@jgiannuzzi jgiannuzzi self-assigned this Aug 17, 2023
Copy link
Collaborator

@dsuhinin dsuhinin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in scope of what I can understand.

Copy link
Contributor

@suprjinx suprjinx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgiannuzzi jgiannuzzi merged commit 7dba664 into G-Research:main Aug 17, 2023
17 checks passed
@jgiannuzzi jgiannuzzi deleted the python-format branch August 17, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants