Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore functionality to update the website when a release is created #493

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

jgiannuzzi
Copy link
Member

Now that release.yml can run directly under the context of a tag (#452), the workflow that updates the website after a release doesn't work anymore — and if it did, it could deploy an older version of the website!
This PR fixes that by trigger a workflow run on the default branch via workflow_dispatch, rather than reusing the workflow on the same reference via workflow_call. Yes, GitHub Actions can get pretty arcane 😬

Copy link

@dave-gantenbein dave-gantenbein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@jgiannuzzi jgiannuzzi self-assigned this Oct 18, 2023
@jgiannuzzi jgiannuzzi added the ci CI related label Oct 18, 2023
@jgiannuzzi jgiannuzzi merged commit aa3ae35 into G-Research:main Oct 18, 2023
18 checks passed
@jgiannuzzi jgiannuzzi deleted the release-website-update branch October 18, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci CI related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants