Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Use the same event name for the backend receipt event #149

Merged
merged 2 commits into from
Sep 28, 2024

Conversation

ogarciarevett
Copy link
Collaborator

This pull request focuses on renaming events in the MiddlewareStakerNativeTokenV1 contract and updating the corresponding test cases. The most important changes include renaming the events to more concise names and ensuring the test cases reflect these changes.

Event Renaming:

  • Renamed StakedInMiddleware to Staked in contracts/upgradeables/governance/MiddlewareStakerNativeTokenV1.sol [1] [2].
  • Renamed UnstakeInitiatedInMiddleware to UnstakeInitiated in contracts/upgradeables/governance/MiddlewareStakerNativeTokenV1.sol.
  • Renamed UnstakedInMiddleware to Unstaked in contracts/upgradeables/governance/MiddlewareStakerNativeTokenV1.sol.

Test Case Updates:

  • Updated event name from StakedInMiddleware to Staked in test/hardhatTests/middlewareStaker.test.ts [1] [2] [3] [4] [5] [6].
  • Updated event name from UnstakeInitiatedInMiddleware to UnstakeInitiated in test/hardhatTests/middlewareStaker.test.ts.

Copy link

openzeppelin-code bot commented Sep 28, 2024

Fix: Use the same event name for the backend receipt event

Generated at commit: 1a7510a470007e6f4ed300d3f9579340df714f4c

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
2
3
0
10
40
55
Dependencies Critical
High
Medium
Low
Note
Total
1
0
0
0
0
1

For more details view the full report in OpenZeppelin Code Inspector

@ogarciarevett ogarciarevett merged commit 6240e81 into main Sep 28, 2024
1 check passed
@ogarciarevett ogarciarevett deleted the feat/SUM-898-handle-staking-middleware branch September 28, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants