[tablemin03] 프론트엔드 3주차 미션 제출합니다. #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hhhkdev
reviewed
Jan 4, 2025
Comment on lines
+1
to
+38
| import js from '@eslint/js' | ||
| import globals from 'globals' | ||
| import react from 'eslint-plugin-react' | ||
| import reactHooks from 'eslint-plugin-react-hooks' | ||
| import reactRefresh from 'eslint-plugin-react-refresh' | ||
|
|
||
| export default [ | ||
| { ignores: ['dist'] }, | ||
| { | ||
| files: ['**/*.{js,jsx}'], | ||
| languageOptions: { | ||
| ecmaVersion: 2020, | ||
| globals: globals.browser, | ||
| parserOptions: { | ||
| ecmaVersion: 'latest', | ||
| ecmaFeatures: { jsx: true }, | ||
| sourceType: 'module', | ||
| }, | ||
| }, | ||
| settings: { react: { version: '18.3' } }, | ||
| plugins: { | ||
| react, | ||
| 'react-hooks': reactHooks, | ||
| 'react-refresh': reactRefresh, | ||
| }, | ||
| rules: { | ||
| ...js.configs.recommended.rules, | ||
| ...react.configs.recommended.rules, | ||
| ...react.configs['jsx-runtime'].rules, | ||
| ...reactHooks.configs.recommended.rules, | ||
| 'react/jsx-no-target-blank': 'off', | ||
| 'react-refresh/only-export-components': [ | ||
| 'warn', | ||
| { allowConstantExport: true }, | ||
| ], | ||
| }, | ||
| }, | ||
| ] |
There was a problem hiding this comment.
해당 eslint 코드는 직접 작성한 것일까요 아니면 기본 템플릿인가여?
eslint를 적용하는 연습을 하는건 지금 단계에서는 쓸모 없을지 몰라도 의미 있는 프로젝트를 진행할 경우에는 큰 도움이 될거라 생각합니당
There was a problem hiding this comment.
확인해보니까 기본 템플릿인가보네여 따로 추가하신게 있는지 모르겟지만 옵션이 이것저것 많으니 이용해보시면 좋을거 같습니당
Comment on lines
+21
to
+28
| @keyframes logo-spin { | ||
| from { | ||
| transform: rotate(0deg); | ||
| } | ||
| to { | ||
| transform: rotate(360deg); | ||
| } | ||
| } |
There was a problem hiding this comment.
애니메이션까지 추가한게 인상적이네여 프론트에서 눈에 보이는 것 중 가장 확실한게 애니메이션이라 생각하는 편이라 잘 연습하면 조금 있어보이는(?) 개발자가 될 수 있다고 생각합니당
There was a problem hiding this comment.
이거도 확인해보니까 vite에서 기본적으로 제공하는 css인거 같네여 나중에는 페이지에 이것저것 애니메이션도 추가해보면 좋을거 같습니당
Comment on lines
+23
to
+27
| const confirmLogin = (event) =>{ | ||
| event.preventDefault(); | ||
| if(email === User.email && pw === User.pw){ | ||
| alert('로그인 성공') | ||
| navigate('/succeed'); |
There was a problem hiding this comment.
아주 간단한 로그인 기능을 잘 구현하셧네요! 다만 여기서 로그인을 성공했을 때만 Succeed 페이지로 이동할 수 있도록 앞서 배운 토큰/세션/쿠키의 개념을 이용하면 좋을거 같아여
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.