[clo-or] 프론트엔드 3주차 미션 제출합니다. #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hhhkdev
reviewed
Jan 4, 2025
Comment on lines
+9
to
+20
| useEffect(() => { | ||
| // localStorage에서 토큰 확인 | ||
| const token = localStorage.getItem("authToken"); | ||
| if (token === "mock-jwt-token-12345") { | ||
| setIsAuthenticated(true); | ||
| } | ||
| }, []); | ||
|
|
||
| const handleLogout = () => { | ||
| localStorage.removeItem("authToken"); // 로그아웃 시 토큰 삭제 | ||
| setIsAuthenticated(false); | ||
| }; |
There was a problem hiding this comment.
앞서 배운 토큰의 개념을 잘 활용하여 작성했다는 생각이 드네요!
Comment on lines
+18
to
+26
| const user = USERS[userId]; | ||
| if (user && user.password === password) { | ||
| setError(""); | ||
| localStorage.setItem("authToken", user.token); | ||
| setAuth(true); | ||
| } else { | ||
| setError("Invalid username or password"); | ||
| } | ||
| }; |
There was a problem hiding this comment.
로그인에서 에러 처리도 확실하게 되었다는 생각이 드네요 다만 로그인에 성공했을 경우에 바로 페이지로 이동하게 해도 좋을거 같습니당
Comment on lines
+3
to
+7
| const USERS = { | ||
| testUser: { | ||
| password: "password123", | ||
| token: "mock-jwt-token-12345", | ||
| }, |
There was a problem hiding this comment.
목데이터를 만들어서 테스트하는게 좋긴하네요 추후에는 따로 파일을 분리해서 public 폴더에서 관리해봐도 좋을거 같습니당
| const decrement = () => setCount(count - step); | ||
|
|
||
| return ( | ||
| <div style={{ margin: '1rem', textAlign: 'center' }}> |
There was a problem hiding this comment.
깔끔한 카운터네요 여기에 스타일을 바로 때려넣기보단 css 파일을 분리하거나 styled component 혹은 emotion에 대해 알아보면 좋을거 같습니당
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.