Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[brayden1102] 프론트엔드 3주차 미션 제출합니다. #6

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

brayden1102
Copy link

No description provided.

Copy link
Collaborator

@hhhkdev hhhkdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아쉽게도 로그인쪽은 아직 구현이 마무리되지 않았엇네요 토큰 관련한 개념 살펴보시고 간단하게나마 데이터를 넘기는 것만이라도 테스트 해보면 좋을듯 합니다 개발 코스도 화이팅입니다~

Comment on lines +24 to +27
Counter.propTypes = {
initialValue: PropTypes.number.isRequired,
changeAmount: PropTypes.number.isRequired,
};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prop-types라는 친구를 처음보는데 어떤 이유로 넣게 됐는지가 궁금합니다! 나머지 코드는 기본적인 카운터 기능에 충실하네여

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants