Feature: Search page 구현 #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- dom에 직접 사용하는 용어인 isVisible이나 translateY같은 단어를 사용하면 props로만 남지 않고 dom에 직접 영향을 줄 수 있다고 해서 일단 급 수정
- 깜빡하고 커밋 안함
- form 안에서 input을 작성하고 엔터를 누르면 가장 앞에 있는 button 태그를 누르게 됩니다. 그래서 가장 가까이에 있는 뒤로가기 버튼을 누르는 것을 확인 - 뒤로가기는 버튼이지만 /search에서 / 으로 바뀌는 링크 전환이기 때문에 a 태그로 변경했어요. - clear 버튼을 통해서 input 내용을 전부 지우는 행위를 하는건 button이 맞지만 div 태그로 바꿨어요.
- 스크롤이 잘 먹도록 레이아웃 조절을 했어요 - 불필요한 콘솔은 삭제하고 map을 리액트에서 적용할 경우 key를 사용해 하는 김에 Divider 컴포넌트도 분리해서 꽂았어요.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature: Search page 구현
PR을 한 이유 🎯
이슈 번호 📎