Auth 회원가입 및 로그인 기능 구현 #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member 참조 -> member_id로 표현
|
엇 spotless 주석 처리된 걸로 올라가버렸네요,, |
cmj7271
reviewed
Jan 24, 2025
|
|
||
| private String password; | ||
| private String refresh; | ||
| private String expiration; |
There was a problem hiding this comment.
토큰 만료시간 같은데 LocalDateTime 이런걸로 안해도 되나요?
(진짜 모름)
There was a problem hiding this comment.
덕분에 찾아봤는데, 보통 Long이나 String을 추천한다고 하네용
| Auth auth = Auth.builder() | ||
| .member(member) | ||
| .password(bCryptPasswordEncoder.encode(joinDto.password())) | ||
| .role("ROLE_USER") |
There was a problem hiding this comment.
혹시 이건 어떤 role 인가요? 일반 회원과 운영진인가여
그리고 enum 으로 따로 관리하면 어떨까요
There was a problem hiding this comment.
네, 일반 유저와 관리자입니다.
enum으로 바꿀게요.
|
refresh token 발급 기능 추가 후, 다시 올릴 예정입니다 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.