Check layer format in layer decorator #1895
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of checking for the format in the addLayer method before calling the layer decorator method the layer format should be checked in the layer decorator method itself as this method will also be called from the [location] layer entry method which will otherwise err.
With the check for the format a warning will be issued if the format is missing in the infoj layer entry method.
The layer entry decorate method should shortcircuit on the existence of the openlayers layer property
.L
not the show method instead of conditionally calling the decorator method on a nullish condition of the show [method] entry property.┆Issue is synchronized with this Asana task by Unito