Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opacity Slider Fix #1899

Merged
merged 2 commits into from
Feb 17, 2025
Merged

Conversation

simon-leech
Copy link
Contributor

@simon-leech simon-leech commented Feb 14, 2025

Pull Request Template

Description

We need to ensure that opacitySlider is provided in the nullish assignment to layer.style.elements to ensure that the slider can be seen when style.opacitySlider = true is set.

GitHub Issue

#1898

Type of Change

Please delete options that are not relevant, and select all options that apply.

  • ✅ Bug fix (non-breaking change which fixes an issue)

Testing Checklist

Please delete options that are not relevant, and select all options that apply.

  • ✅ Existing Tests still pass

Code Quality Checklist

Please delete options that are not relevant, and select all options that apply.

  • ✅ My code follows the guidelines of XYZ
  • ✅ My code has been commented
  • ✅ Documentation has been updated
  • ✅ New and existing unit tests pass locally with my changes

┆Issue is synchronized with this Asana task by Unito

@simon-leech simon-leech added the Bug A genuine bug. There must be some form of error exception to work with. label Feb 14, 2025
@simon-leech simon-leech linked an issue Feb 14, 2025 that may be closed by this pull request
@simon-leech simon-leech marked this pull request as ready for review February 14, 2025 09:36
@RobAndrewHurst RobAndrewHurst merged commit 4c352a0 into GEOLYTIX:patch Feb 17, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A genuine bug. There must be some form of error exception to work with.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

opacitySlider is never seen
5 participants