Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guidance, update schema descriptions, add taxonomy mappings, replace normative keywords #239

Merged
merged 19 commits into from
Sep 4, 2023

Conversation

odscjen
Copy link
Contributor

@odscjen odscjen commented Sep 1, 2023

Related issues

Description

Merge checklist

If you added, removed or renamed a field:

  • Update the collapse option of the jsonschema directives for dataset, resource, hazard, exposure, vulnerability and loss on reference/schema.md
  • Update the diagrams in reference/schema/md
  • Update the JSON files in examples

Always:

  • Run ./manage.py pre-commit
  • Update the changelog (style guide)

Having trouble?

See how to resolve check failures.

@odscjen
Copy link
Contributor Author

odscjen commented Sep 1, 2023

I've just converted that gdoc into actual markdown, @odscrachel (realised I should have mentioned this to you a minute ago) can make any of the changes you think are necessary while I'm off.

@odscjen odscjen mentioned this pull request Sep 1, 2023
3 tasks
@duncandewhurst
Copy link
Contributor

I didn't get a chance to review the content in the Google Doc so I've copy-edited the Markdown files directly.

I'm happy for this to be merged as-is so I'll request a review from Stu and Mat.

@duncandewhurst duncandewhurst requested review from stufraser1 and matamadio and removed request for duncandewhurst September 4, 2023 01:19
@duncandewhurst duncandewhurst changed the title 149 docs guides pages Add guidance, update schema descriptions, add taxonomy mappings, replace normative keywords Sep 4, 2023
@duncandewhurst
Copy link
Contributor

I see a 👍 from @stufraser1 on #149 (comment) so I figure this is good to merge. If needed, we can make changes in a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants