Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pre-commit configuration: enforce pyright and optimize local testing #234

Merged
merged 3 commits into from
Jan 24, 2025

Conversation

saleml
Copy link
Collaborator

@saleml saleml commented Jan 24, 2025

Changes:

  • Added pyright with proper project configuration
  • Added type: ignore comments for current type issues (to be resolved later)
  • Modified local pre-commit test scope to only run tests in testing/ folder
  • Preserved full test suite requirement in GitHub CI

Note: While some type issues are temporarily ignored, they will need to be addressed in future PRs. The change maintains code quality while improving developer experience through faster local commits.

Copy link
Collaborator

@josephdviviano josephdviviano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm -- thanks for your attention to detail here

@saleml saleml mentioned this pull request Jan 24, 2025
Copy link
Collaborator

@younik younik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@josephdviviano josephdviviano merged commit 5db4162 into master Jan 24, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants