Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attribute-completeness: do not create figure if no objects are present #834

Merged
merged 24 commits into from
Oct 10, 2024

Conversation

Gigaszi
Copy link
Collaborator

@Gigaszi Gigaszi commented Oct 10, 2024

Skip figure creation if calculation could not be made and add to description that no elements are present.

Corresponding issue

Closes #829

Checklist

  • I have updated my branch to main (e.g. through git rebase main)
  • My code follows the style guide and was checked with pre-commit before committing
    - [ ] I have commented my code
    - [ ] I have added sufficient unit and integration tests
  • I have updated the CHANGELOG.md

Gigaszi and others added 24 commits October 8, 2024 15:47
fix: invalid example GeoJSON in swagger
Co-authored-by: Matthias Merdes <[email protected]>
Copy link
Collaborator

@mmerdes mmerdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐟

@mmerdes mmerdes merged commit e1f5765 into main Oct 10, 2024
2 checks passed
@mmerdes mmerdes deleted the 829-fix-figure-creation branch October 10, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

figure creation fails for attribute-completeness
3 participants