feat: Add topojson graph export rebase #1926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelsJP
force-pushed
the
feat/add-topojson-graph-export-rebase
branch
from
807ea6d to
aff6244
Compare
takb
force-pushed
the
feat/add-topojson-graph-export-rebase
branch
from
e60e4aa to
9b7530f
Compare
koebi
approved these changes
Dec 10, 2024
ors-api/src/main/java/org/heigit/ors/api/controllers/ExportAPI.java
Outdated
Show resolved
Hide resolved
koebi
requested changes
Dec 10, 2024
ors-engine/src/main/java/org/heigit/ors/export/ExportRequest.java
Outdated
Show resolved
Hide resolved
ors-engine/src/main/java/org/heigit/ors/export/ExportRequest.java
Outdated
Show resolved
Hide resolved
takb
force-pushed
the
feat/add-topojson-graph-export-rebase
branch
from
2b1cfa4 to
3f8ad0d
Compare
sfendrich
reviewed
Dec 11, 2024
ors-api/src/main/java/org/heigit/ors/api/responses/export/topojson/Network.java
Outdated
Show resolved
Hide resolved
ors-api/src/main/java/org/heigit/ors/api/responses/export/topojson/TopoJsonExportResponse.java
Outdated
Show resolved
Hide resolved
koebi
approved these changes
Dec 13, 2024
…port This implements the first rough TopoJson objects to construct the coming TopoJson export endpoint.
includes pingtests in various permutations of faulty and correct input
Let's not add Lombok to existing classes. Only new ones for now. Hence, this fiel gets a typical setter.
Before the "coordinates" keyword was still serialized wrongly into the topojson structure creating a wrong arcs structure.
Reduce unnecessary duplication and streamline the export serialization with e.g. JsonExportResponse. The only difference is that it doesn't extent the ExportResponse. This is also not necessary. ExportResponse holds no value for the TopoJson export.
Layers is not necessary. It can be represented by a HashMap of layers where the key is the layer name. In our case "network".
… properties replacing weight with speed/distance, fallback for cases where OSM ids are not available, using OSM way geometries (with option to turn off and get only node coordinates (beeline graph) instead)
…eter "debug" to "additional_info"
…onse.fromExportResult()
Chwiggy
force-pushed
the
feat/add-topojson-graph-export-rebase
branch
from
96ea04e to
69b0efb
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
have been resolved.
[Unreleased] heading.
along with a short description of what it is for, and documented this in the Pull Request (below).
(at least Germany), and the graphs build without problems (i.e. no out-of-memory errors).
importer etc.), I have generated longer distance routes for the affected profiles with different options
(avoid features, max weight etc.) and compared these with the routes of the same parameters and start/end
points generated from the current live ORS.
If there are differences then the reasoning for these MUST be documented in the pull request.
and why the change was needed.
Information about the changes
TopoJSON response type on the export endpoint. Returns a TopoJSON representation of the graph within a given bounding box containing the ORS edges and nodes, OSM ways with ID, a flag is passable both ways, speeds and distances.