Skip to content

Commit

Permalink
remove recommendation to noop JSEvents_requestFullscreen since it see…
Browse files Browse the repository at this point in the history
…ms to be working now?
  • Loading branch information
justinlaughlin committed Aug 23, 2024
1 parent 27ffb33 commit 726d9ed
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -130,14 +130,6 @@ More info [here](https://docs.npmjs.com/updating-your-published-package-version-
- Opening new examples results in memory growth
- Fullscreen events captured by the Emscripten Module are difficult to control
- `_JSEvents_requestFullscreen` in _glvis.js_ takes over the whole screen
- For now we patch this to be a noop
- Setting a noop with `emscripten_set_fullscreenchange_callback` doesn't seem to do it
- `_emscripten_set_canvas_element_size` and `__set_canvas_element_size` print
errors and duplicate some existing behavior

- Lots of console warnings
Expand Down

0 comments on commit 726d9ed

Please sign in to comment.