Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix leak in jeeps serial comm on posix. #1223

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Conversation

tsteven4
Copy link
Collaborator

@tsteven4 tsteven4 commented Nov 16, 2023

This resolves #1221

I have tested this with a GPS12, "vtesto -l -j vg.log sgt.test", and:
gpsbabel -D3 -i garmin -f /dev/ttyS0
gpsbabel -D3 -i gpx -f w.gpx -o garmin -F /dev/ttyS0

both operations succeeded and no leaks were detected.

  • This test was done on a hyper-v gen 1 ubuntu 22 guest running under a windows 11 host.
  • The serial port was emulated through a USB to RS232 Converter Cable https://ftdichip.com/products/chipi-x10/.
  • A windows named pipe was connected to the emulated serial port via https://github.com/tdhoward/COMpipe with the command "COMpipe.exe -b 9600 -c \\.\COM3 -p \\.\pipe\gen1ubuntu22".
  • The hyper-v guest settings set guest COM 1 to the named pipe gen1ubuntu22.

@tsteven4
Copy link
Collaborator Author

thanks @tdhoward for COMpipe.

@robertlipe
Copy link
Collaborator

I used to build serial drivers (and hardware) professionally. We were dealing with things that werent really a 16450 running on a Real Computer but virtualizing down to a 16450 in DOS so that Procomm and Kermit and things that wanted to do outb()'s on 0x3f8 would actually go through ISA shared memory commands, be read by one processor that packetetized that and generated sync packets, then shipped them over potentially a modem or even an SDLC connection, then get picked off the wire and command (alien) uarts on the other side of all that to do their bidding. It was a beautiful series of hacks when it worked ... and a hell of a train wreck when it didn't.

So of course I approve the PR, but I have a warm feeling about that glorious testing process. Nicely done!

@tsteven4 tsteven4 merged commit 1d74ab7 into GPSBabel:master Nov 16, 2023
18 of 19 checks passed
@tsteven4 tsteven4 deleted the jeepsleak branch November 19, 2023 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GPS serial memory leak?
2 participants