Fix argument count check for ops with only a variadic argument list. #93
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't count variadic arguments in the
getNumFullArguments()
method since they can be zero. Not properly checking the return value of this function can however lead to aarg_size() < 0
check in the generated verifier method. This happens if we only have a single variadic argument list argument.This could also be solved with a call to
std::max
but just let us not emit verifier code instead.