Improve lit testing scripts. #94
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Let `check-llvm-dialects-lit` depend on the `llvm-dialects-test-depends` custom target - Convert `add_dialects_unit_test` to a macro
tsymalla
force-pushed
the
fix_test_target_dependency
branch
from
f748363 to
c11f6ba
Compare
nhaehnle
reviewed
May 23, 2024
| ) | ||
| set_target_properties(check-llvm-dialects-lit PROPERTIES FOLDER "Tests") |
There was a problem hiding this comment.
Why did you remove this? AFAIK it is relevant for Visual Studio.
There was a problem hiding this comment.
It is already set on llvm-dialects-test-depends (not sure if it works though, going to double-check)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check-llvm-dialects-litdepend on thellvm-dialects-test-dependscustom targetadd_dialects_unit_testto a macro