Feature/adaptive moving puncture #171
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazewong
force-pushed
the
feature/adaptive_moving_puncture
branch
from
a803fe5 to
90ed830
Compare
* Prepend hdf5_path to restart_file when checking Fixes #172 * Add more CH_USE_HDF5 guards The guarded code is unnecessary if building without HDF5. * Move `pout_prefix` under CH_MPI guards This parameter is irrelevant when compiling without MPI.
kazewong
force-pushed
the
feature/adaptive_moving_puncture
branch
from
c87547d to
6b786ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding adaptive moving puncture. The initial request contains 3 commits:
Passing cell coordinate to CCZ4RHS and MovingPunctureGauge
This commit passes the cell coordinate object to the CCZ4RHS and subsequently the gauge. It is expected to be compatible with the original main branch (commit #a48c11813e861578deeb27c289c1583987442c69) since no actual change is made in the computation.
Change MovingPunctureGauge class to use adaptive gaussian around each puncture
Add gaussian smoothing to advection coefficient according to the puncture masses. This commit is not expected to be compatible with the default behaviour, which assumes eta to be constant throughout the whole simulation domain. I think there should be a way to switch on and off this adaptive behaviour. A better way to define this will be making a new gauge class, however, I failed to compile the code when I create a new gauge class and try to pass it to
CCZ4RHS<>{}in BinaryBHLevel.cpp. It complains about the need to use the original MovingPunctureGauge params, which is not defined in the new gauge class.Update MovingPunctureGauge adaptive parameters in BinaryBHLevel.cpp
Make corresponding changes in BinaryBHLevel.cpp to update the puncture location in the gauge during the simulation.