Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make clear we're going to be in dialogue. #106

Merged
merged 3 commits into from
Mar 28, 2024

Conversation

jadudm
Copy link
Contributor

@jadudm jadudm commented Mar 27, 2024

Also links to the advanced search page.

Subject to further edits, etc.

Also links to the advanced search page.
@jadudm jadudm requested a review from lauraherring March 27, 2024 14:57
@lauraherring
Copy link
Contributor

I think it would be better to use other channels for the dialog than the website and to instead just remove the mentions of April 16 for now. I made a commit to do this and fix the link to the advanced search page.

Copy link
Contributor

@lauraherring lauraherring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good with removing April 16 mentions.

@jadudm
Copy link
Contributor Author

jadudm commented Mar 27, 2024

I feel like there's two problems with this edit:

  1. The mention of the findings workbooks is now hidden in a collapsed accordion. It is not visible on the page.
  2. The why and wherefore of those resources is now described on a page that is very difficult to find/navigate to, because it does not exist save for access from a single link at the bottom of the collapsed accordion.

I would like to recommend we leave mention of this at the top of the status page, because it is critical information for our paying customers who are engaged in financial oversight. I can offer a PR tomorrow, or we can pair.

@lauraherring lauraherring merged commit ee4f548 into main Mar 28, 2024
3 checks passed
@lauraherring lauraherring deleted the jadudm/findings-page-suggestions branch March 28, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants