Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Workbook Versions to 1.0.5 #96

Merged
merged 3 commits into from
Mar 28, 2024
Merged

Bump Workbook Versions to 1.0.5 #96

merged 3 commits into from
Mar 28, 2024

Conversation

jperson1
Copy link
Contributor

@jperson1 jperson1 commented Mar 20, 2024

Bump Workbook Versions to 1.0.5

Issue: GSA-TTS/FAC#3490

Changes:

  1. Add FMCSA as valid cluster name:
  2. New validations on the reference number in the CAP text and findings text workbooks

@jperson1 jperson1 requested a review from a team March 20, 2024 13:35
@jperson1 jperson1 self-assigned this Mar 20, 2024
@jadudm
Copy link
Contributor

jadudm commented Mar 20, 2024

Does this update the relevant validation pathways to allow v1.0.5 workbooks?

Ah. Sorry. Did the relevant changes already happen in the app, I guess is my question.

If so, I'll approve this through.

@jperson1
Copy link
Contributor Author

@jadudm Yes! The apps-side changes are complete, this PR is to update the templates that users can access.

The last change to workbooks was from PR GSA-TTS/FAC#3513, which went into production this morning (https://github.com/GSA-TTS/FAC/releases/tag/v1.2040320).

Copy link
Contributor

@jadudm jadudm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@jadudm jadudm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jperson1 jperson1 merged commit a1dc986 into main Mar 28, 2024
3 checks passed
@jperson1 jperson1 deleted the jp/workbook-bump-105 branch March 28, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants