Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do smoketest when scaling catalog-web #1510

Merged
merged 6 commits into from
Jan 14, 2025
Merged

Do smoketest when scaling catalog-web #1510

merged 6 commits into from
Jan 14, 2025

Conversation

nickumia
Copy link
Contributor

Apparently it hasn't been causing issues, but it seems like a safe thing to do in any case 🤷‍♀️

image

@FuhuXia
Copy link
Member

FuhuXia commented Jan 14, 2025

In order to let a LEGIT PR from a fork to use our GitHub secret, we can replicate the PR into a DRAFT PR and run github action there.

Steps:

git fetch origin pull/1510/head:add-smoketest
git push origin add-smoketest

@FuhuXia FuhuXia merged commit 1e19b81 into GSA:main Jan 14, 2025
9 of 10 checks passed
@FuhuXia FuhuXia mentioned this pull request Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants