Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ngda #176

Merged
merged 6 commits into from
Nov 30, 2023
Merged

Ngda #176

merged 6 commits into from
Nov 30, 2023

Conversation

FuhuXia
Copy link
Member

@FuhuXia FuhuXia commented Nov 30, 2023

For GSA/data.gov#4165.

  • add NGDA marker for datasets tagged NGDA
  • reduce bottom padding for resource label by 1px
  • add top/bottom border around maps

@FuhuXia
Copy link
Member Author

FuhuXia commented Nov 30, 2023

Currently deployed on catalog-dev.

@FuhuXia FuhuXia marked this pull request as ready for review November 30, 2023 20:16
@FuhuXia FuhuXia requested a review from a team November 30, 2023 21:18
FuhuXia added a commit to GSA/catalog.data.gov that referenced this pull request Nov 30, 2023
Copy link
Contributor

@jbrown-xentity jbrown-xentity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests make me feel warm and fuzzy... Thanks @FuhuXia !

@jbrown-xentity jbrown-xentity merged commit 7df2949 into main Nov 30, 2023
4 checks passed
@jbrown-xentity jbrown-xentity deleted the ngda branch November 30, 2023 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants