Save auth metadata in session storage #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jfredrickson5 Thank you! I just showed Andrew how to clear localStorage because he is giving a demo tomorrow. If it's okay with you, let's wait until tomorrow after his demo to merge this. |
Merged
mark-meyer
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The auth metadata stored in localStorage is specific to each environment. When we started using multiple environments, this presented a problem where the user would not be able to log in unless they manually went in to clear their localStorage data. This change switches from using localStorage to sessionStorage. That way, the user just has to end their session in order to be able to sign in to a different environment.