Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

milk no longer removes thaumcraft warp effect #26

Merged
merged 1 commit into from
Jan 19, 2025

Conversation

MissBismuth
Copy link

Fixes: GTNewHorizons/GT-New-Horizons-Modpack#18804
Thaumcraft effects caused by warp remove the default curative item (milk bucket), calling the curePotionEffects method only removes effects that should be cleared by milk instead of all.
To test this, you can't give yourself any of the effects (like unnatural hunger) with the /effect command. You have to give yourself warp and wait for the effect to be applied by the warp.

Copy link
Member

@serenibyss serenibyss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving since this should handle warp nicely, though I think this will still clear Nutrition potion effects, something to be aware of (though this is speculative, I haven't tested it)

@serenibyss serenibyss merged commit 43a2cfa into GTNewHorizons:master Jan 19, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drinking Milk from Adventures Backpack can Remove Warp Effects
2 participants