Convert ASM to mixin #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Once this is merged, I am going to work on a way to recover any items in the BG2 slots. |
|
Slowly going through this as I also use it in a playthrough |
Caedis
approved these changes
Jul 26, 2024
src/main/java/xonin/backhand/mixins/early/MixinNetHandlerPlayServer.java
Outdated
Show resolved
Hide resolved
Caedis
approved these changes
Jul 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts all the asm to mixins and ditches mysteriumlib. There's likely some bugs or something I missed so I'd love it if someone wanted to test it out.
A couple of the transformers were replacing inventory array calls with
BackhandUtils.setPlayerCurrentItem, this is an inherited thing from bg2 and from my testing doesn't seem to be required for Backhand and have thus been removed & not converted.