Fix TiC battle sign not working in offhand #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TiC handles the battle sign interactions during
LivingHurtEventandLivingAttackEvent, these events can't be safely posted twice like we do with thePlayerInteractEventas all sorts of things are mutated during them.We can however safely re-invoke it for some event listeners such as TiC which enables them to also check the offhand item.
The same idea can be applied to EFR's totem check along with TiC's crossbow crosshair rendering and the mixins we were using for those previously can be removed.
Closes #52