Refactor packets #59
Merged
Refactor packets #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serenibyss
reviewed
Jan 26, 2025
src/main/java/xonin/backhand/mixins/early/minecraft/MixinNetHandlerPlayClient.java
Outdated
Show resolved
Hide resolved
serenibyss
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses GTNHLib's SyncedKeybind which enables us to remove the two packets that were previously used for swapping items to/from the offhand and the 2 remaining packets have been refactored to standard IMessages.
Hopefully fixes https://discord.com/channels/181078474394566657/603348502637969419/1333064415083364356 by implementing some stricter checks to ensure that items from fake players aren't synced. I don't know for sure if this fixes it since I can't reproduce, but that packet is only used to sync the items other players are holding in their offhand and it wouldn't ordinarily be sent in SP.