Better Assline checkresult #3863
Merged
+9
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dream-Master
added
the
🚧 Testing on Zeta
serenibyss
approved these changes
Jan 26, 2025
serenibyss
removed
the
🚧 Testing on Zeta
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When AL/AAL has multiple datasticks and all datasticks fails in recipe check, AL/AAL will only display the fail reason for the last datastick.
For example 2 datasticks, one for a UHV recipe another for a ZPM recipe.
Assline has UHV recipe inputs, but has only a ZPM Energy Hatch.
Assline might display either "insufficient power" or "no recipe", which is confusing and unpredictable.
This PR makes AL/AAL only overwrite the checkresult when it is NO_DATA_STICKS.
That means, if previous datasticks' check fails in an interesting way (insufficient power/output full), AL/AAL will keep it
and do not overwrite it with "no recipe".