Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover UI crash fixes #3873

Merged
merged 5 commits into from
Jan 31, 2025
Merged

Cover UI crash fixes #3873

merged 5 commits into from
Jan 31, 2025

Conversation

YannickMG
Copy link
Contributor

Fixes 2 separate crashes identified in GTNewHorizons/GT-New-Horizons-Modpack#18343.

One was about caching cover data before it was set and needed, the other was about opening a cover UI before we had received that cover's data.

@YannickMG YannickMG added the bug fix Fix a bug. Please link it in the PR. label Jan 30, 2025
@YannickMG YannickMG requested a review from a team January 30, 2025 20:26
@serenibyss serenibyss merged commit 5753cd4 into master Jan 31, 2025
5 checks passed
@serenibyss serenibyss deleted the cover-ui-crash-fixes branch January 31, 2025 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix Fix a bug. Please link it in the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants