Remove 2MB chunk size limit #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested in full pack now and it works. |
|
but how does it behave on hybrid servers? Like thermos has it already iirc |
|
The mixin is set to not run when bukkit is detected |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports https://github.com/CrucibleMC/Crucible/blob/staging/patches/net/minecraft/world/chunk/storage/RegionFile.java.patch to mixins to allow saving&loading chunks with more than 2MB of data in them.
Tested using a new command that can attach random byte arrays of a specified size to items, oversized chunks save and load correctly.
Together with the previous packet size patch this means chunkbans are now a thing of the past 🥳